Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolaceIO.Write: add data classes, connector interface #31953

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

iht
Copy link
Contributor

@iht iht commented Jul 23, 2024

This is a followup PR to #31906, and part of the issue #31905

This adds the interface of the Write connector and a few classes (data classes, POutput) that are used by the connector.

More changes are coming in a subsequent PR.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

…1905

This adds the interface of the Write connector and a few classes (data
classes, POutput) that are used by the connector.
@iht iht changed the title This is a followup PR to #31906, and part of the issue #31905 SolaceIO.Write: add data classes, connector interface Jul 23, 2024
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@iht
Copy link
Contributor Author

iht commented Jul 23, 2024

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@shunping
Copy link
Contributor

Code change looks good.

Are we expecting unit and integration tests to come in the follow-up PR?

@iht
Copy link
Contributor Author

iht commented Jul 26, 2024

@shunping Yes, integration tests, and the actual code of the connector are prepared in an upcoming PR. I am sending them in "chunks" because it is thousands of lines of code, to facilitate the review.

@Abacn Abacn merged commit 493e0ba into apache:master Jul 29, 2024
19 checks passed
@Abacn
Copy link
Contributor

Abacn commented Jul 29, 2024

merge this after received a lgtm review above

@iht iht mentioned this pull request Aug 2, 2024
iht added a commit to iht/beam that referenced this pull request Aug 27, 2024
…31905.

This PR adds the actual writer functionality, and some additional
testing, including integration testing.

This should be final PR for the SolaceIO write connector to be
complete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants