Add logging for DataChangeRecord and ChangeStreamQuery #31956
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @m-trieu for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| @@ -85,6 +85,7 @@ public Optional<ProcessContinuation> run( | |||
|
|
|||
| final String token = partition.getPartitionToken(); | |||
| LOG.debug("[{}] Processing data record {}", token, record.getCommitTimestamp()); | |||
There was a problem hiding this comment.
there is already debug log here. One can set --sdkHarnessLogLevelOverrides='{\"org.apache.beam.sdk.io.gcp.spanner.changestreams.action.DataChangeRecordAction\":\"DEBUG\"}'" to enable it. See https://beam.apache.org/releases/javadoc/current/org/apache/beam/sdk/options/SdkHarnessOptions.SdkHarnessLogLevelOverrides.html
| @@ -127,6 +129,7 @@ public ChangeStreamResultSet changeStreamQuery( | |||
| .to(heartbeatMillis) | |||
| .build(); | |||
| } | |||
| LOG.info("Change Stream Statement: [{}] ", statement.toString()); | |||
There was a problem hiding this comment.
in general refrain logging PII (statements can contain PII). If needed could use debug log
|
Reminder, please take a look at this pr: @m-trieu @johnjcasey @nielm |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
|
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @damondouglas for label java. Available commands:
|
|
Reminder, please take a look at this pr: @damondouglas @ahmedabu98 @nielm |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
|
|
Reminder, please take a look at this pr: @robertwb @chamikaramj @nielm |
|
waiting on author |
github-actions
bot
added
Next Action: Author
and removed
Next Action: Reviewers
slow-review
labels
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.