Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#31462] [prism] Correctly chose earliest or latest in pane timestamps for aggregations. #31979

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Jul 25, 2024

Correctly implement the WindowingStrategy OutputTime feature, which specify the event time of outputs from GroupByKeys.

In particular, this allows the test org.apache.beam.sdk.transforms.GroupByKeyTest\$BasicTests.testTimestampCombinerEarliest and similar to pass.

Fixes #31462.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@lostluck
Copy link
Contributor Author

R: @damondouglas

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@lostluck lostluck changed the title [#31438] [prism] Correctly chose earliest or latest in pane timestamps for aggregations. [#31462] [prism] Correctly chose earliest or latest in pane timestamps for aggregations. Jul 25, 2024
@damondouglas damondouglas self-requested a review July 29, 2024 17:17
Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense now that end of window would return MaxTimestamp() and that the second mtime.Time argument of the aggregated output func is the current timestamp.

@lostluck lostluck merged commit 9e431b4 into apache:master Jul 29, 2024
6 checks passed
@lostluck lostluck deleted the beam31438outputtime branch July 29, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prism]: unsupported feature "WindowStrategy.OutputTime" set with value (LATEST|EARLIEST)_IN_PANE
2 participants