-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix StringSet tests on portable runners #31999
Conversation
…gacyRunn…" This reverts commit b129433.
after #31838 now portable runners can see stringset metrics, however, the result is different from non-portable ones and still failing the assert Previous:
now:
checked that
the problem is each result duplicated one more time |
Java PVR Spark Batch two tests failed: testValueStateCoderInferenceFromInputCoder testValueStateCoderInference unrelated to the change Java ULR stringset test failed, still need to exclude it |
Dataflow v2 test Still failing:
will investigate further Other portable runner tests (Flink/Spark) now passing |
4f83c8c
to
03b8b00
Compare
03b8b00
to
03d1008
Compare
Ready for review. Latest commit reverted trigger file change. See test results of f302fb1 |
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Reverts #31818