Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#21515][Go SDK] Update go protobuf package to new version #32045

Merged
merged 10 commits into from
Aug 7, 2024

Conversation

imvtsl
Copy link
Contributor

@imvtsl imvtsl commented Jul 31, 2024

Update go protobuf package to new version.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, for create_test.go the code there is validating that a ProtoV1 message is supported and can be encoded.

You can remove the marshal interface lines.

_ proto.Marshaler   = &testProto{}
_ proto.Unmarshaler = &testProto{}

Since we aren't relying on the protoV1 unmarshalling handlers after this PR.

sdks/go/pkg/beam/coder.go Show resolved Hide resolved
sdks/go/pkg/beam/coder.go Outdated Show resolved Hide resolved
sdks/go/pkg/beam/coder.go Show resolved Hide resolved
sdks/go/pkg/beam/coder.go Show resolved Hide resolved
sdks/go/pkg/beam/core/runtime/graphx/coder.go Outdated Show resolved Hide resolved
sdks/go/pkg/beam/core/runtime/graphx/translate.go Outdated Show resolved Hide resolved
sdks/go/pkg/beam/core/runtime/harness/statemgr.go Outdated Show resolved Hide resolved
@imvtsl
Copy link
Contributor Author

imvtsl commented Aug 3, 2024

retest this please

@imvtsl
Copy link
Contributor Author

imvtsl commented Aug 3, 2024

Similarly, for create_test.go the code there is validating that a ProtoV1 message is supported and can be encoded.

Thank you!! I had no idea about protoadapt package. I was trying to modify create_test.go to somehow work with proto v2 message. This helped clarified the goal of the test case.

You can remove the marshal interface lines.

_ proto.Marshaler   = &testProto{}
_ proto.Unmarshaler = &testProto{}

Since we aren't relying on the protoV1 unmarshalling handlers after this PR.

Done.

@imvtsl imvtsl marked this pull request as ready for review August 3, 2024 03:18
@imvtsl imvtsl requested a review from lostluck August 3, 2024 03:18
@imvtsl
Copy link
Contributor Author

imvtsl commented Aug 3, 2024

@lostluck
Although, this change doesn't impact any users, I believe I still have to add an entry in Changes.md . Do I add the entry under section 2.59.0 or 2.58.0?

@lostluck
Copy link
Contributor

lostluck commented Aug 3, 2024

It would go under 2.59.0 as 2.58 has already been cut and is going to be released next week.

I agree that the change is worth a small note, in the unlikely event that it breaks a protov1 user.

@imvtsl
Copy link
Contributor Author

imvtsl commented Aug 3, 2024

It would go under 2.59.0 as 2.58 has already been cut and is going to be released next week.

I agree that the change is worth a small note, in the unlikely event that it breaks a protov1 user.

Thanks. I pushed the change.

Copy link
Contributor

github-actions bot commented Aug 3, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.
R: @damondouglas for label java.
R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 57.19%. Comparing base (bf42a81) to head (63aa49d).

Files Patch % Lines
sdks/go/container/tools/provision.go 42.85% 2 Missing and 2 partials ⚠️
sdks/python/container/boot.go 0.00% 4 Missing ⚠️
sdks/java/container/boot.go 0.00% 3 Missing ⚠️
sdks/go/pkg/beam/core/runtime/harness/statemgr.go 50.00% 1 Missing ⚠️
sdks/go/pkg/beam/runners/dataflow/dataflow.go 0.00% 1 Missing ⚠️
...o/pkg/beam/runners/dataflow/dataflowlib/execute.go 0.00% 1 Missing ⚠️
...dks/go/pkg/beam/runners/universal/runnerlib/job.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #32045      +/-   ##
============================================
+ Coverage     57.18%   57.19%   +0.01%     
  Complexity     1474     1474              
============================================
  Files           963      963              
  Lines        152697   152818     +121     
  Branches       1076     1076              
============================================
+ Hits          87313    87409      +96     
- Misses        63202    63220      +18     
- Partials       2182     2189       +7     
Flag Coverage Δ
go 34.65% <50.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGES.md Outdated Show resolved Hide resolved
@imvtsl imvtsl requested a review from lostluck August 4, 2024 06:28
@lostluck lostluck changed the title Update go protobuf package to new version [#21515][Go SDK] Update go protobuf package to new version Aug 7, 2024
Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you very much! This is very helpful.

@lostluck lostluck merged commit 828717a into apache:master Aug 7, 2024
51 checks passed
@imvtsl
Copy link
Contributor Author

imvtsl commented Aug 7, 2024

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Go protobuf package to new version
2 participants