Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Java11 test fix #32209

Merged
merged 2 commits into from
Aug 16, 2024
Merged

More Java11 test fix #32209

merged 2 commits into from
Aug 16, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Aug 15, 2024

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

implementation "org.apache.samza:samza-kv-rocksdb_2.11:$samza_version"
implementation "org.apache.samza:samza-kv-inmemory_2.11:$samza_version"
implementation "org.apache.samza:samza-yarn_2.11:$samza_version"
implementation "org.apache.samza:samza-core_$samza_scala:$samza_version"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may affect users, however given that samza 1.6.0 is 3 years old I would consider this more like a long overdue update.

tested validatesRunner still passes on both Java8 and 11

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert Samza changes because actually the version bump is non-trivial. Python Validates Runner Samza test now failing with various reasons. First it is

 java.lang.UnsupportedOperationException: SamzaImpulseSystem doesn't support producing
 	at org.apache.beam.runners.samza.translation.SamzaImpulseSystemFactory.getProducer(SamzaImpulseSystemFactory.java:59)
 	at org.apache.samza.system.SystemFactory.getProducer(SystemFactory.java:66)
 	at org.apache.samza.container.SamzaContainer$.$anonfun$apply$27(SamzaContainer.scala:248)
 	at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:286)
 	...
 	at scala.collection.AbstractTraversable.map(Traversable.scala:108)
 	at org.apache.samza.container.SamzaContainer$.apply(SamzaContainer.scala:245)
 	at org.apache.samza.container.SamzaContainer.apply(SamzaContainer.scala)
 	at org.apache.samza.processor.StreamProcessor.createSamzaContainer(StreamProcessor.java:412)

after change SamzaImpulseSystemFactory.getProducer to return null (as other getProducer), tests then fail with

024-08-15T21:18:38.5903463Z [grpc-default-executor-1] INFO org.apache.beam.runners.fnexecution.control.FnApiControlClientPoolService - getProcessBundleDescriptor request with id 18-4
 Traceback (most recent call last):
   File "/runner/_work/beam/beam/sdks/python/test-suites/portable/py38/build/srcs/sdks/python/apache_beam/runners/common.py", line 1495, in process
     return self.do_fn_invoker.invoke_process(windowed_value)
   File "/runner/_work/beam/beam/sdks/python/test-suites/portable/py38/build/srcs/sdks/python/apache_beam/runners/common.py", line 687, in invoke_process
     self.output_handler.handle_process_outputs(
   File "/runner/_work/beam/beam/sdks/python/test-suites/portable/py38/build/srcs/sdks/python/apache_beam/runners/common.py", line 1681, in handle_process_outputs
     self._write_value_to_tag(tag, windowed_value, watermark_estimator)
   ...
   File "/runner/_work/beam/beam/sdks/python/test-suites/portable/py38/build/srcs/sdks/python/apache_beam/coders/coder_impl.py", line 1259, in get_estimated_size_and_observables
     self._elem_coder.get_estimated_size_and_observables(
   File "/runner/_work/beam/beam/sdks/python/test-suites/portable/py38/build/srcs/sdks/python/apache_beam/coders/coder_impl.py", line 291, in get_estimated_size_and_observables
     return self.estimate_size(value, nested), []
   File "/runner/_work/beam/beam/sdks/python/test-suites/portable/py38/build/srcs/sdks/python/apache_beam/coders/coder_impl.py", line 282, in estimate_size
     return self._get_nested_size(self._size_estimator(value), nested)
   File "/runner/_work/beam/beam/sdks/python/test-suites/portable/py38/build/srcs/sdks/python/apache_beam/coders/coders.py", line 209, in estimate_size
     return len(self.encode(value))
   File "/runner/_work/beam/beam/sdks/python/test-suites/portable/py38/build/srcs/sdks/python/apache_beam/coders/coders.py", line 407, in encode
     return value.encode('utf-8')
 AttributeError: 'numpy.int64' object has no attribute 'encode'

* Fix Java IOs/HCatalogIO PreCommit typo

* Run Spark3 Version PreCommit on Java8

* Tun Samza tests on Java8
@Abacn
Copy link
Contributor Author

Abacn commented Aug 16, 2024

Involved tests:

PostCommit Java ValidatesRunner Samza: https://github.com/apache/beam/actions/runs/10411089794

PostCommit Python ValidatesRunner Samza: https://github.com/apache/beam/actions/runs/10411090450

PostCommit XVR Samza: https://github.com/apache/beam/actions/runs/10411091254

PreCommit Java Spark3 Versions: https://github.com/apache/beam/actions/runs/10411096758

PreCommit Java HCatalog IO Direct: https://github.com/apache/beam/actions/runs/10411100175 show 18 tests

PostCommit Java Hadoop Versions: https://github.com/apache/beam/actions/runs/10411102961

PostCommit Java PVR Samza: https://github.com/apache/beam/actions/runs/10411552878

@Abacn Abacn marked this pull request as ready for review August 16, 2024 04:32
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Aug 16, 2024

R: @damccorm

@Abacn
Copy link
Contributor Author

Abacn commented Aug 16, 2024

R: @lostluck

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm damccorm merged commit 83a3db5 into master Aug 16, 2024
23 of 24 checks passed
@damccorm damccorm deleted the fixjava11test branch August 16, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants