-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Java11 test fix #32209
More Java11 test fix #32209
Conversation
runners/samza/build.gradle
Outdated
implementation "org.apache.samza:samza-kv-rocksdb_2.11:$samza_version" | ||
implementation "org.apache.samza:samza-kv-inmemory_2.11:$samza_version" | ||
implementation "org.apache.samza:samza-yarn_2.11:$samza_version" | ||
implementation "org.apache.samza:samza-core_$samza_scala:$samza_version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may affect users, however given that samza 1.6.0 is 3 years old I would consider this more like a long overdue update.
tested validatesRunner still passes on both Java8 and 11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert Samza changes because actually the version bump is non-trivial. Python Validates Runner Samza test now failing with various reasons. First it is
java.lang.UnsupportedOperationException: SamzaImpulseSystem doesn't support producing
at org.apache.beam.runners.samza.translation.SamzaImpulseSystemFactory.getProducer(SamzaImpulseSystemFactory.java:59)
at org.apache.samza.system.SystemFactory.getProducer(SystemFactory.java:66)
at org.apache.samza.container.SamzaContainer$.$anonfun$apply$27(SamzaContainer.scala:248)
at scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:286)
...
at scala.collection.AbstractTraversable.map(Traversable.scala:108)
at org.apache.samza.container.SamzaContainer$.apply(SamzaContainer.scala:245)
at org.apache.samza.container.SamzaContainer.apply(SamzaContainer.scala)
at org.apache.samza.processor.StreamProcessor.createSamzaContainer(StreamProcessor.java:412)
after change SamzaImpulseSystemFactory.getProducer
to return null (as other getProducer), tests then fail with
024-08-15T21:18:38.5903463Z [grpc-default-executor-1] INFO org.apache.beam.runners.fnexecution.control.FnApiControlClientPoolService - getProcessBundleDescriptor request with id 18-4
Traceback (most recent call last):
File "/runner/_work/beam/beam/sdks/python/test-suites/portable/py38/build/srcs/sdks/python/apache_beam/runners/common.py", line 1495, in process
return self.do_fn_invoker.invoke_process(windowed_value)
File "/runner/_work/beam/beam/sdks/python/test-suites/portable/py38/build/srcs/sdks/python/apache_beam/runners/common.py", line 687, in invoke_process
self.output_handler.handle_process_outputs(
File "/runner/_work/beam/beam/sdks/python/test-suites/portable/py38/build/srcs/sdks/python/apache_beam/runners/common.py", line 1681, in handle_process_outputs
self._write_value_to_tag(tag, windowed_value, watermark_estimator)
...
File "/runner/_work/beam/beam/sdks/python/test-suites/portable/py38/build/srcs/sdks/python/apache_beam/coders/coder_impl.py", line 1259, in get_estimated_size_and_observables
self._elem_coder.get_estimated_size_and_observables(
File "/runner/_work/beam/beam/sdks/python/test-suites/portable/py38/build/srcs/sdks/python/apache_beam/coders/coder_impl.py", line 291, in get_estimated_size_and_observables
return self.estimate_size(value, nested), []
File "/runner/_work/beam/beam/sdks/python/test-suites/portable/py38/build/srcs/sdks/python/apache_beam/coders/coder_impl.py", line 282, in estimate_size
return self._get_nested_size(self._size_estimator(value), nested)
File "/runner/_work/beam/beam/sdks/python/test-suites/portable/py38/build/srcs/sdks/python/apache_beam/coders/coders.py", line 209, in estimate_size
return len(self.encode(value))
File "/runner/_work/beam/beam/sdks/python/test-suites/portable/py38/build/srcs/sdks/python/apache_beam/coders/coders.py", line 407, in encode
return value.encode('utf-8')
AttributeError: 'numpy.int64' object has no attribute 'encode'
* Fix Java IOs/HCatalogIO PreCommit typo * Run Spark3 Version PreCommit on Java8 * Tun Samza tests on Java8
Involved tests: PostCommit Java ValidatesRunner Samza: https://github.com/apache/beam/actions/runs/10411089794 PostCommit Python ValidatesRunner Samza: https://github.com/apache/beam/actions/runs/10411090450 PostCommit XVR Samza: https://github.com/apache/beam/actions/runs/10411091254 PreCommit Java Spark3 Versions: https://github.com/apache/beam/actions/runs/10411096758 PreCommit Java HCatalog IO Direct: https://github.com/apache/beam/actions/runs/10411100175 show 18 tests PostCommit Java Hadoop Versions: https://github.com/apache/beam/actions/runs/10411102961 PostCommit Java PVR Samza: https://github.com/apache/beam/actions/runs/10411552878 |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
R: @damccorm |
R: @lostluck |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fix Java IOs/HCatalogIO PreCommit typo
Run Spark3 Version PreCommit on Java8 - opened [Failing Test]: Java Samza runner tests failing on Java11 #32208 to track Samza runner Java11 support
Run Samza tests on Java8 - opened [Failing Test]: SparkVersionTest 3.4.0+ fails on Java11 #32207 to track Spark 3.4.0+ runner Java11 support
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.