Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextIO.read() split with non-default delimiter #32298

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Amar3tto
Copy link
Contributor

@Amar3tto Amar3tto commented Aug 23, 2024

Resolves #32251


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the java label Aug 23, 2024
@Amar3tto Amar3tto marked this pull request as ready for review August 23, 2024 14:47
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Amar3tto
Copy link
Contributor Author

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@@ -672,8 +672,8 @@ public void testReadStringsWithCustomDelimiter() throws Exception {
"To be, or not to be: that |is the question: ",
// incomplete delimiter
"To be, or not to be: that *is the question: ",
// complete delimiter
"Whether 'tis nobler in the mind to suffer |*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we preserve this existing line case. just add one more line to test *||**|, like

// complete delimiter
"Whether 'tis nobler in the mind to suffer |*",
// edge case: partial delimiter then complete delimiter
"The slings and arrows of outrageous fortune,*||**|"
// truncated delimiter
"Or to take arms against a sea of troubles,|"

@Amar3tto
Copy link
Contributor Author

Run Java_GCP_IO_Direct PreCommit

@Abacn Abacn merged commit 46cdc4b into apache:master Aug 23, 2024
28 checks passed
@baeminbo
Copy link
Contributor

baeminbo commented Sep 2, 2024

Could you check #32251 (comment)? I think this PR cannot fix all the cases of the issue #32251.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TextIO.read() with non-default delimiter doesn't split at the right position
3 participants