Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick #32178: Loose BigQuery GCP project ID regex restrictions #32314

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

kberezin-nshl
Copy link
Contributor

Cherry pick of this PR: #32178

cc @lostluck

@lostluck
Copy link
Contributor

It does not make the cut to require a new RC to be generated (it's clearly not a release blocker), but it's also so small in scope to not be a problem.

So what will happen is I'll look at this again in the morning, and most likely merge it in. That way, if there's a release blocking issue in RC1, it will be included in RC2. Otherwise it'll have to wait until 2.60.0.

@kberezin-nshl
Copy link
Contributor Author

Great, thank you @lostluck .

It is quite a big annoyance for us, so we'd appreciate removing our dirty hacks to work that around after migrating to 2.59. But obviously not that a big deal because we have workarounds in place.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.
R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@shunping shunping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

R: @damondouglas for final approval

@liferoad liferoad added this to the 2.59.0 Release milestone Aug 26, 2024
@lostluck lostluck removed this from the 2.59.0 Release milestone Aug 26, 2024
@lostluck lostluck merged commit 37d41fd into apache:release-2.59.0 Aug 26, 2024
17 checks passed
@lostluck
Copy link
Contributor

Due to the conditional nature of the cherry pick, It should not be added to the release milestone at this time. It may or may not make it into 2.59.0, per reasons I stated above. It will be a part of 2.60.0 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants