[Dataflow Streaming] Add support to read user worker settings from backend #32408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunpandianp
force-pushed
the
settings
branch
6 times, most recently
from
60e62f0
to
98a306a
Compare
arunpandianp
changed the title
|
R: @scwhittle |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
scwhittle
requested changes
Sep 9, 2024
...ker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java
Outdated
Show resolved
Hide resolved
...e/beam/runners/dataflow/worker/streaming/config/StreamingEngineComputationConfigFetcher.java
Outdated
Show resolved
Hide resolved
arunpandianp
force-pushed
the
settings
branch
from
98a306a
to
e7b705d
Compare
|
Run Java Precommit |
|
Run Precommit Java |
|
Run Java Precommit |
|
This is ready for review, the failing test looks unrelated to the change. |
scwhittle
requested changes
Sep 12, 2024
...ker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java
Outdated
Show resolved
Hide resolved
...va/org/apache/beam/runners/dataflow/worker/streaming/config/StreamingGlobalConfigHandle.java
Outdated
Show resolved
Hide resolved
...va/org/apache/beam/runners/dataflow/worker/streaming/config/StreamingGlobalConfigHandle.java
Outdated
Show resolved
Hide resolved
...va/org/apache/beam/runners/dataflow/worker/streaming/config/StreamingGlobalConfigHandle.java
Outdated
Show resolved
Hide resolved
...rg/apache/beam/runners/dataflow/worker/streaming/config/StreamingGlobalConfigHandleImpl.java
Outdated
Show resolved
Hide resolved
...rg/apache/beam/runners/dataflow/worker/streaming/config/StreamingGlobalConfigHandleImpl.java
Outdated
Show resolved
Hide resolved
...rg/apache/beam/runners/dataflow/worker/streaming/config/StreamingGlobalConfigHandleImpl.java
Outdated
Show resolved
Hide resolved
...org/apache/beam/runners/dataflow/worker/windmill/work/processing/StreamingWorkScheduler.java
Outdated
Show resolved
Hide resolved
scwhittle
requested changes
Sep 13, 2024
| */ | ||
| package org.apache.beam.runners.dataflow.worker.streaming.config; | ||
|
|
||
| import com.google.common.base.Preconditions; |
There was a problem hiding this comment.
Done. Should we remove the unvendored dependency from the classpath somehow?
...va/org/apache/beam/runners/dataflow/worker/streaming/config/FixedGlobalConfigHandleTest.java
Show resolved
Hide resolved
...pache/beam/runners/dataflow/worker/streaming/config/StreamingGlobalConfigHandleImplTest.java
Show resolved
Hide resolved
...pache/beam/runners/dataflow/worker/streaming/config/StreamingGlobalConfigHandleImplTest.java
Show resolved
Hide resolved
...va/org/apache/beam/runners/dataflow/worker/streaming/harness/StreamingWorkerStatusPages.java
Outdated
Show resolved
Hide resolved
...rg/apache/beam/runners/dataflow/worker/streaming/config/StreamingGlobalConfigHandleImpl.java
Outdated
Show resolved
Hide resolved
|
todo: Manage the threadpool shutdown |
|
Modified StreamingGlobalConfigHandleImpl to queue callbacks internally without relying on executors. PTAL |
scwhittle
requested changes
Sep 18, 2024
...va/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java
Outdated
Show resolved
Hide resolved
...pache/beam/runners/dataflow/worker/streaming/config/StreamingGlobalConfigHandleImplTest.java
Outdated
Show resolved
Hide resolved
...va/org/apache/beam/runners/dataflow/worker/streaming/harness/StreamingWorkerStatusPages.java
Outdated
Show resolved
Hide resolved
...rg/apache/beam/runners/dataflow/worker/streaming/config/StreamingGlobalConfigHandleImpl.java
Show resolved
Hide resolved
.../java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcDispatcherClient.java
Show resolved
Hide resolved
...orker/src/test/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorkerTest.java
Outdated
Show resolved
Hide resolved
...pache/beam/runners/dataflow/worker/streaming/config/StreamingGlobalConfigHandleImplTest.java
Show resolved
Hide resolved
...pache/beam/runners/dataflow/worker/streaming/config/StreamingGlobalConfigHandleImplTest.java
Show resolved
Hide resolved
scwhittle
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #32407.