-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bigquery fixes #32780
Bigquery fixes #32780
Conversation
2cef99c
to
a489849
Compare
a489849
to
770e73d
Compare
R: @damccorm |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just had one comment, otherwise this LGTM
sdks/python/apache_beam/transforms/enrichment_handlers/bigquery.py
Outdated
Show resolved
Hide resolved
27006f9
to
b17abe9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32780 +/- ##
============================================
+ Coverage 58.84% 58.90% +0.05%
Complexity 3091 3091
============================================
Files 1130 1131 +1
Lines 174044 174444 +400
Branches 3320 3312 -8
============================================
+ Hits 102414 102753 +339
- Misses 68293 68360 +67
+ Partials 3337 3331 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Yaml test failures are unrelated and failing at head, so merging
Fix the following BigQuery enrichment transform issues
Issues 1 and 2 are fixed by keying batched requests by a tuple of values.
Issue 3 is fixed by wrapping conditions in parenthesis.
Also modify integration tests to
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.