Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up logger handling for boot.go script in Python SDK #33015

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

willvo2004
Copy link

fixes #29819

Unsure if it is safe to add an accessor method within the buffer logger file. Otherwise the proposed changes addresses the issue and gradle build tests on the corresponding modules are successful.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@willvo2004 willvo2004 marked this pull request as draft November 5, 2024 04:08
@willvo2004
Copy link
Author

Failed Gradle tasks:
Task :sdks:python:test-suites:tox:py39:testPy39CloudCoverage FAILED
Task :sdks:go:goTest FAILED

@willvo2004
Copy link
Author

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Clean up logger handling in Python's boot.go script
1 participant