Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make saml auth request option forceauthn configurable #9756

Open
wants to merge 1 commit into
base: 4.19
Choose a base branch
from
Open

make saml auth request option forceauthn configurable #9756

wants to merge 1 commit into from

Conversation

DaanHoogland
Copy link
Contributor

Description

This PR...

Fixes: #9701

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland DaanHoogland added this to the 4.20.1.0 milestone Oct 2, 2024
@DaanHoogland
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.08%. Comparing base (e666dca) to head (bfcee3c).
Report is 25 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #9756      +/-   ##
============================================
- Coverage     15.08%   15.08%   -0.01%     
- Complexity    11184    11185       +1     
============================================
  Files          5402     5402              
  Lines        473170   473171       +1     
  Branches      59687    61314    +1627     
============================================
- Hits          71371    71369       -2     
- Misses       393859   393864       +5     
+ Partials       7940     7938       -2
Flag Coverage Δ
uitests 4.29% <ø> (ø)
unittests 15.80% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11257

@DaanHoogland
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-11600)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60218 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9756-t11600-kvm-ol8.zip
Smoke tests completed. 136 look OK, 2 have errors, 3 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_secure_vm_migration Error 134.12 test_vm_life_cycle.py
test_01_secure_vm_migration Error 134.12 test_vm_life_cycle.py
test_01_redundant_vpc_site2site_vpn Error 542.26 test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options Error 339.74 test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options Error 339.75 test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:teardown Error 446.23 test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup Error 580.99 test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup Error 654.50 test_vpc_vpn.py
all_test_webhook_delivery Skipped --- test_webhook_delivery.py
all_test_webhook_lifecycle Skipped --- test_webhook_lifecycle.py
all_test_host_maintenance Skipped --- test_host_maintenance.py

@DaanHoogland
Copy link
Contributor Author

errors seem unrelated retrying

@DaanHoogland
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

sureshanaparti
sureshanaparti approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti
Copy link
Contributor

@vishesh92 can this be part of 4.19.2 milestone?

@vishesh92
Copy link
Member

@vishesh92 can this be part of 4.19.2 milestone?

It can be

@blueorangutan
Copy link

[SF] Trillian test result (tid-11615)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 73080 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9756-t11615-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_secure_vm_migration Error 404.97 test_vm_life_cycle.py
test_02_redundant_VPC_default_routes Failure 450.38 test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Failure 438.32 test_vpc_redundant.py
test_05_rvpc_multi_tiers Failure 514.84 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 514.86 test_vpc_redundant.py

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@DaanHoogland DaanHoogland changed the base branch from main to 4.19 October 7, 2024 13:29
@DaanHoogland DaanHoogland modified the milestones: 4.20.1.0, 4.19.2.0 Oct 7, 2024
@DaanHoogland DaanHoogland reopened this Oct 7, 2024
@DaanHoogland
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11296

@DaanHoogland
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-11628)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47068 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9756-t11628-kvm-ol8.zip
Smoke tests completed. 129 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestRouterServices>:setup Error 0.00 test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup Error 0.00 test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup Error 0.37 test_service_offerings.py
ContextSuite context=TestSetSourceNatIp>:setup Error 0.00 test_set_sourcenat.py
test_10_attachAndDetach_iso Error 12.93 test_vm_life_cycle.py

@DaanHoogland
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-11637)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 42518 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9756-t11637-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland marked this pull request as ready for review October 9, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishesh92 vishesh92 vishesh92 left review comments

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees
No one assigned
Labels
component:kvm component:saml component:storage type:enhancement type:improvement
Projects
None yet
Milestone
4.19.2.0
Development

Successfully merging this pull request may close these issues.

SAML: Not able to login if the user is already logged in on another application in the browser
4 participants
@DaanHoogland @blueorangutan @sureshanaparti @vishesh92