Skip to content

Commit

Permalink
fix bug in bitmap_count
Browse files Browse the repository at this point in the history
  • Loading branch information
Yoruet committed Oct 13, 2024
1 parent 5066efa commit 195d27f
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions be/src/vec/functions/function_bitmap.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ class FunctionBitmapCount : public IFunction {

size_t get_number_of_arguments() const override { return 1; }

bool use_default_implementation_for_nulls() const override { return true; }
bool use_default_implementation_for_nulls() const override { return false; }

Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments,
size_t result, size_t input_rows_count) const override {
Expand All @@ -506,7 +506,10 @@ class FunctionBitmapCount : public IFunction {
auto column = block.get_by_position(arguments[0]).column;
auto str_col = assert_cast<const ColumnBitmap*>(column.get());
const auto& col_data = str_col->get_data();

if (auto* nullable = check_and_get_column<const ColumnNullable>(*column)) {
VectorizedUtils::update_null_map(null_map, nullable->get_null_map_data());
column = nullable->get_nested_column_ptr();
}
res.reserve(input_rows_count);
for (size_t i = 0; i < input_rows_count; ++i) {
if (null_map[i]) {
Expand Down

0 comments on commit 195d27f

Please sign in to comment.