[fix](json) fix invalid json which should not be insert #39932
+1,345
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38192 ms |
TPC-DS: Total hot run time: 191164 ms |
ClickBench: Total hot run time: 30.67 s |
morrySnow
reviewed
Aug 28, 2024
| @@ -32,6 +34,13 @@ public class JsonLiteral extends Literal { | |||
|
|
|||
| private static final ObjectMapper MAPPER = new ObjectMapper(); | |||
|
|
|||
| static { | |||
| // 启用严格的 JSON 验证配置 | |||
| static { | ||
| // 启用严格的 JSON 验证配置 | ||
| MAPPER.enable(DeserializationFeature.FAIL_ON_TRAILING_TOKENS); | ||
| MAPPER.enable(JsonParser.Feature.STRICT_DUPLICATE_DETECTION); |
There was a problem hiding this comment.
this should be remove since be accept duplicate key in json
Comment on lines
+40
to
+41
| MAPPER.enable(JsonParser.Feature.STRICT_DUPLICATE_DETECTION); | ||
| MAPPER.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES); |
There was a problem hiding this comment.
this should be removed because it is used for java object deserialization
xiaokang
changed the title
xiaokang
reviewed
Sep 27, 2024
| @@ -69,6 +69,9 @@ endif() | |||
| # enable glog custom prefix | |||
| add_definitions(-DGLOG_CUSTOM_PREFIX_SUPPORT) | |||
|
|
|||
| # enable simdjson check eof | |||
| add_definitions(-DSIMDJSON_CHECK_EOF) | |||
There was a problem hiding this comment.
The official comment in simdjson does not suggest turn it on.
option(SIMDJSON_CHECK_EOF "Check for the end of the input buffer. The setting is unnecessary since we require padding of the inputs. You should expect tests to fail with this option turned on." OFF)
There was a problem hiding this comment.
if we do not add this, we should check in our logic for input string buffer which has error ending
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix invalid json which should not be insert
add simdjson lib check micro and fix fe fastjson param
Issue Number: close #xxx