[opt](function) optimize from_unixtime/date_format by specially format str #40821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 42981 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 195149 ms |
ClickBench: Total hot run time: 31.46 s |
Mryange
changed the title
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 42617 ms |
|
run performance |
TPC-H: Total hot run time: 42938 ms |
TPC-DS: Total hot run time: 194889 ms |
ClickBench: Total hot run time: 30.97 s |
HappenLee
reviewed
Sep 14, 2024
| #include <variant> | ||
|
|
||
| #include "vec/common/string_ref.h" | ||
| namespace doris::vectorized { |
There was a problem hiding this comment.
doris::vectorized::time_format_type
HappenLee
reviewed
Sep 14, 2024
| namespace time_format_type { | ||
|
|
||
| template <typename T> | ||
| void inline put_year(T y, char* buf, int& i) { |
There was a problem hiding this comment.
no need inline, the template func must be inline
HappenLee
reviewed
Sep 14, 2024
| res_data.reserve(len * format.size + len); | ||
| null_map.resize_fill(len, false); | ||
|
|
||
| if (!format_state->is_valid) { |
There was a problem hiding this comment.
is_valid should set null, is danger behavioer
|
run buildall |
TPC-H: Total hot run time: 43291 ms |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run performance |
TPC-H: Total hot run time: 41228 ms |
TPC-DS: Total hot run time: 198385 ms |
ClickBench: Total hot run time: 33.73 s |
zhangstar333
approved these changes
Sep 18, 2024
dataroaring
pushed a commit
that referenced
this pull request
Oct 9, 2024
…t str (#40821) ``` mysql [test]>select count(date_format(a, 'yyyyMMdd')) from date_format_tmp; +-----------------------------------+ | count(date_format(a, 'yyyyMMdd')) | +-----------------------------------+ | 16000000 | +-----------------------------------+ 1 row in set (0.53 sec) mysql [test]>select count(date_format(a, 'yyyyMMdd')) from date_format_tmp; +-----------------------------------+ | count(date_format(a, 'yyyyMMdd')) | +-----------------------------------+ | 16000000 | +-----------------------------------+ 1 row in set (0.28 sec) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes