Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](inverted index) fix match null for inverted index #41746

Merged
merged 3 commits into from
Oct 14, 2024
Merged

[Fix](inverted index) fix match null for inverted index #41746

merged 3 commits into from
Oct 14, 2024
+40 −33

Conversation

airborne12
Copy link
Member

Proposed changes

str match null return null , not true event if str is null

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@airborne12
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.39% (9658/25827)
Line Coverage: 28.68% (80173/279569)
Region Coverage: 28.09% (41438/147504)
Branch Coverage: 24.70% (21108/85454)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ca8fe5b4472ed8d633848a47d74c1b2110227451_ca8fe5b4472ed8d633848a47d74c1b2110227451/report/index.html

@airborne12
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.39% (9663/25844)
Line Coverage: 28.65% (80149/279789)
Region Coverage: 28.08% (41439/147554)
Branch Coverage: 24.70% (21101/85444)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6f5432be458246848fe3e56d93ad0b3b8e7ac445_6f5432be458246848fe3e56d93ad0b3b8e7ac445/report/index.html

eldenmoon
eldenmoon approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

csun5285
csun5285 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12 airborne12 merged commit 6a6455d into apache:master Oct 14, 2024
24 of 27 checks passed
@airborne12 airborne12 deleted the fix-null-index branch October 14, 2024 04:17
This was referenced Oct 14, 2024
Open
Open
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Oct 14, 2024
@airborne12
[Fix](inverted index) fix match null for inverted index (apache#41746)
e09c636 
## Proposed changes

str match null return null , not true event if str is null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

@csun5285 csun5285 csun5285 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/3.0.x reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@airborne12 @doris-robot @eldenmoon @csun5285