Fix ModuleCapability/ModuleRequirement hashcode/equals according to API #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API of Capability/Requirement currently defines the contract to be: This Capability/Requirement is equal to another Capability/Requirement if they have the same namespace, directives and attributes and are declared by the same resource. But Felix currently implements hashCode/equals in terms of object identity.
stbischof
reviewed
Feb 22, 2024
| @@ -45,6 +46,7 @@ public class BundleCapabilityImpl implements BundleCapability | |||
| private final Map<String, Object> m_attrs; | |||
| private final List<String> m_uses; | |||
| private final Set<String> m_mandatory; | |||
| private transient int hashCode; | |||
There was a problem hiding this comment.
the formatting may use the same number of tabs as before
Not sure what you are asking here. Probably a question for @karlpauls
Need caution here as I remember Richard Hall and I designing the resource and resolver APIs such that the framework can use identity equality for capabilities and bundle revisions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API of Capability/Requirement currently defines the contract to be: This Capability/Requirement is equal to another Capability/Requirement if they have the same namespace, directives and attributes and are declared by the same resource.
But Felix currently implements hashCode/equals in terms of object identity.
This is the counterpart for