Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github verification for SCR #321

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Add github verification for SCR #321

merged 1 commit into from
Jun 14, 2024

Conversation

laeubi
Copy link

@laeubi laeubi commented May 17, 2024

This adds a github verification workflow for the scr component of felix dev.

I created an example PR how it would looks like after the merge here:

FYI @tjwatson @stbischof I think this should be merged first as it does not require any changes to the code itself to make it run, once we have this we can rebase

on this and further enhance it.

@stbischof
Copy link
Contributor

stbischof commented May 17, 2024

@tjwatson would it be okay if a merge in felix?

I have the rights. But maybe there are some more rules.

@tjwatson
Copy link
Member

@tjwatson would it be okay if a merge in felix?

I have the rights. But maybe there are some more rules.

It is fine with me to merge. Please merge if you think it is ready. Although it will not do anything until we get the repo enabled for actions.

@laeubi
Copy link
Author

laeubi commented May 17, 2024

Currently the test parser complains about to large xml data:
https://github.com/laeubi/felix-dev/pull/3/checks?check_run_id=25087687495

we could either keep this, or I disable the processing of the test files for now or as it only affects the integration test, disable only upload of integration tests...

@stbischof
Copy link
Contributor

just upload and no publish

why do you use "stCarolas/setup-maven" and noch the default actions?

@paulrutter
Copy link
Contributor

The default actions don't let you specify a maven version.

@stbischof
Copy link
Contributor

and what feature has 3.9.6 that we need?

@laeubi
Copy link
Author

laeubi commented Jun 1, 2024

just upload and no publish

why do you use "stCarolas/setup-maven" and noch the default actions?

What do you mean by default actions?

One can't tell for sure what the runner have installed (java+maven version) and it might even change or differ between os so for me its good "style" to install wanted java version and wanted maven version.

and what feature has 3.9.6 that we need?

I don't think there is any certain "feature" just to control what is used as otherwhise it might give surprising results.

@laeubi
Copy link
Author

laeubi commented Jun 1, 2024

just upload and no publish

done

This adds a github verification workflow for the scr component of felix
dev.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants