Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FELIX-6720 enable virtual thread support in jetty12 #329

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

paulrutter
Copy link
Contributor

  • Add org.apache.felix.http.jetty.virtualthreads.enable as configuration option, defaulting to false
  • Add logging if virtual threads are used
  • Use reflection to detect if Virtual Threads can be used and throw if this is enabled but cannot be used
  • Add integration test

I haven't tested it myself yet (apart from the IT), so before merging we should make sure it works properly.

- Add `org.apache.felix.http.jetty.virtualthreads.enable` as configuration option, defaulting to false
- Add logging if virtual threads are used
- Use reflection to detect if Virtual Threads can be used and throw if this is enabled but cannot be used
- Add integration test
@paulrutter paulrutter changed the title Feature/felix 6720 enable virtual thread support in jetty12 Felix-6720 enable virtual thread support in jetty12 Jul 10, 2024
@paulrutter paulrutter changed the title Felix-6720 enable virtual thread support in jetty12 FELIX-6720 enable virtual thread support in jetty12 Jul 10, 2024
@stbischof
Copy link
Contributor

@timothyjward
May be interesting to what the Performance difference is.

@paulrutter
Copy link
Contributor Author

Having read the webtide blogs, it's not a silver bullet, although it can help in some situations though.

https://webtide.com/if-virtual-threads-are-the-solution-what-is-the-problem/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants