Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FELIX-6189 - Make sure jar/zip files are jailed to the destination di… #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FELIX-6189 - Make sure jar/zip files are jailed to the destination di… #5

wants to merge 1 commit into from

Conversation

coheigea
Copy link
Contributor

@coheigea coheigea commented Mar 3, 2020

…rectory

@jbonofre jbonofre self-requested a review March 3, 2020 09:58
@jbonofre
Copy link
Member

jbonofre commented Mar 3, 2020

Not sure it's a good idea. This kind of change already breaks Felix Utils. Let me do a pass and also reopen about Felix Utils.

@karlpauls
Copy link
Contributor

@jbonofre, did you manage to try it out?

@jbonofre
Copy link
Member

@karlpauls I will, but definitely, the same change broke Felix Utils (it has to be fixed by the way). So, I will do a pass on both. Sorry for the delay.

@coheigea
Copy link
Contributor Author

@jbonofre What's the problem with Felix Utils?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbonofre jbonofre Awaiting requested review from jbonofre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coheigea @jbonofre @karlpauls