Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Format integration tests code #1263

Merged
merged 7 commits into from
Dec 27, 2023

Conversation

chaokunyang
Copy link
Collaborator

  • Format integration tests code
  • Upgrade spotless plugin to support JDK 17&21
  • Format java code using upgraded spotless plugin

@chaokunyang chaokunyang merged commit 224cd03 into apache:main Dec 27, 2023
16 checks passed
@@ -246,7 +246,8 @@
<configuration>
<java>
<googleJavaFormat>
<version>1.7</version>
<!-- 1.19.1 support JDK21 -->
<version>1.19.1</version>
<style>GOOGLE</style>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll suggest we use the plantir style for longer line length and better breaking lines strategy.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will do this in another PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plantir style seems doesn't support 2 spaces: palantir/palantir-java-format#951. I suggest continuing to use google code style

@nandakumar131
Copy link
Contributor

Spotless plugin version upgrade breaks spotless:apply in Java 8. (#1278)

@chaokunyang chaokunyang deleted the format_integration_tests_code branch April 1, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants