Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Release Fury Java Snapshot #1264

Merged
merged 7 commits into from
Dec 27, 2023
Merged

ci: Release Fury Java Snapshot #1264

merged 7 commits into from
Dec 27, 2023

Conversation

tisonkun
Copy link
Member

No description provided.

@tisonkun tisonkun marked this pull request as draft December 27, 2023 08:13
Signed-off-by: tison <[email protected]>
@tisonkun tisonkun marked this pull request as ready for review December 27, 2023 08:17
@tisonkun tisonkun marked this pull request as draft December 27, 2023 08:18
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
@tisonkun tisonkun marked this pull request as ready for review December 27, 2023 08:40
@tisonkun tisonkun merged commit a8f081b into main Dec 27, 2023
17 checks passed
@tisonkun tisonkun deleted the release-java-snapshot branch December 27, 2023 08:40

<profiles>
<profile>
<id>release</id>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found that remove this part will skip jar release in sub modules.

Fury use properties to skip module deploy, deploy plugin won't be enabled without this profile

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. They are released - https://repository.apache.org/content/groups/snapshots/org/apache/fury/

We now inherit with Apache Maven Parent POM which contains an apache-release profile to help.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants