Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Fix fury benchmark jmh GPLV2 license conflict #1272

Merged
merged 12 commits into from
Jan 2, 2024

Conversation

chaokunyang
Copy link
Collaborator

@chaokunyang chaokunyang commented Dec 28, 2023

This PR closes #1271 by:

  • Remove java/fury-benchmark from fury java module. In this way, when users/developers compiles and install fury from source, jmh won't be downloaded by default.
  • Make jmh depdendency as optional, and only avlaiable when activating jmh profile.

According to apache license doc: https://www.apache.org/legal/resolved.html#optional
image

I believe GPLv2 license conflict has been addressed.

@chaokunyang chaokunyang force-pushed the fix_fury_benchmark_jmh_license branch 2 times, most recently from bf39e59 to 61a3520 Compare January 2, 2024 06:19
@chaokunyang chaokunyang force-pushed the fix_fury_benchmark_jmh_license branch from ef9fdcc to 729483e Compare January 2, 2024 06:25
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chaokunyang chaokunyang merged commit 1134cce into apache:main Jan 2, 2024
16 checks passed
@chaokunyang chaokunyang deleted the fix_fury_benchmark_jmh_license branch April 1, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java][License] GPLv2 license of jmh benchmark tool conflict with ASF's license policy
3 participants