ci(c++): Implement C++ CI scripts using python #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiangliangSui
force-pushed
the
main
branch
7 times, most recently
from
7b1434d
to
5cc874c
Compare
|
PTAL, thanks. |
|
Could we add windows CI in this PR? |
|
Windows CI has not been added yet, windows bazel requires some additional configuration, I am trying it locally based on the current For the current linux and mac os C++ CI, it can work. Maybe we can merge the pr first. |
PragmaTwice
reviewed
Jan 4, 2024
PragmaTwice
reviewed
Jan 4, 2024
PragmaTwice
reviewed
Jan 4, 2024
PragmaTwice
reviewed
Jan 4, 2024
LiangliangSui
force-pushed
the
main
branch
2 times, most recently
from
605f9a3
to
21a572f
Compare
chaokunyang
reviewed
Jan 4, 2024
PragmaTwice
reviewed
Jan 5, 2024
PragmaTwice
reviewed
Jan 5, 2024
PragmaTwice
reviewed
Jan 5, 2024
PragmaTwice
reviewed
Jan 5, 2024
PragmaTwice
reviewed
Jan 5, 2024
PragmaTwice
reviewed
Jan 5, 2024
PragmaTwice
reviewed
Jan 5, 2024
PragmaTwice
changed the title
PragmaTwice
changed the title
|
Hi @PragmaTwice, It has been revised according to the comments mentioned. In addition, the local adaptation of Windows C++ CI has been completed in the past two days. After this PR is merged, another PR will be created to implement the final adaptation of Windows C++ CI. |
chaokunyang
reviewed
Jan 8, 2024
Signed-off-by: LiangliangSui <[email protected]>
|
Can this PR be merged? If possible, please help me merge it. I don’t have the permission to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement C++ CI scripts using python.