Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(JavaScript): Fix JavaScript test CI #1355

Merged
merged 1 commit into from
Jan 24, 2024
Merged

chore(JavaScript): Fix JavaScript test CI #1355

merged 1 commit into from
Jan 24, 2024

Conversation

theweipeng
Copy link
Member

@theweipeng theweipeng commented Jan 23, 2024 •
edited
Loading

  1. JavaScript codebase contains a c++ module which requires the nodejs version greater than 20, we should ignore it when the version is not satisfied to prevent it from breaking test ci
  2. Remove coverage threshold temporarily before the xlang protocol release
  3. Add 14.x and 16.x to the docker envs

#1350

@theweipeng theweipeng enabled auto-merge (squash) January 24, 2024 03:39
chaokunyang
chaokunyang approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theweipeng theweipeng merged commit 5e89732 into apache:main Jan 24, 2024
24 checks passed
@LiangliangSui
Copy link
Contributor

node 16 still fails in this pr ci， see https://github.com/apache/incubator-fury/actions/runs/7628690034/job/20780349832#step:4:105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang chaokunyang approved these changes

@bytemain bytemain Awaiting requested review from bytemain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theweipeng @LiangliangSui @chaokunyang @bytemain