Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kotlin): Add Unsigned Primitive Support #1886

Merged
merged 15 commits into from
Oct 16, 2024
Merged

feat(kotlin): Add Unsigned Primitive Support #1886

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a3ab95a
add simple primitive serialization test.
wywen Oct 15, 2024
1b0b13f
add nullable primitive serializer tests.
wywen Oct 15, 2024
e4d462a
implement and register unsigned primitive serializers.
wywen Oct 15, 2024
a86ef28
Add boundary testing for unsigned classes.
wywen Oct 15, 2024
edce8fd
add info to README.md on primitives.
wywen Oct 15, 2024
d1fdb68
add a note to nullable tests.
wywen Oct 15, 2024
3f557e7
add comments to unsigned serializers.
wywen Oct 15, 2024
64ed2cc
use writeByte
wywen Oct 16, 2024
5c92e80
Use readByte
wywen Oct 16, 2024
8538e3e
Use readWriteVarUint16
wywen Oct 16, 2024
4f701d2
Revert "Use readWriteVarUint16"
wywen Oct 16, 2024
eafa066
fixup for linter
wywen Oct 16, 2024
ee9a5fa
use writeInt16/readInt16 for more compact representation.
wywen Oct 16, 2024
90108ba
default java implementation -> fury java implementation
wywen Oct 16, 2024
736f293
Revert "use writeInt16/readInt16 for more compact representation."
wywen Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kotlin/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Fury Kotlin provides additional tests and implementation support for Kotlin type
Fury Kotlin is tested and works with the following types:

- primitives: `Byte`, `Boolean`, `Int`, `Short`, `Long`, `Char`, `Float`, `Double`, `UByte`, `UShort`, `UInt`, `UShort`, `UInt`.
- `Byte`, `Boolean`, `Int`, `Short`, `Long`, `Char`, `Float`, `Double` works out of the box with the default java implementation.
- `Byte`, `Boolean`, `Int`, `Short`, `Long`, `Char`, `Float`, `Double` works out of the box with the default java implementation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we replace all default java implementation with default fury java implementation

- stdlib `collection`: `ArrayDeque`, `ArrayList`, `HashMap`,`HashSet`, `LinkedHashSet`, `LinkedHashMap`.
- `ArrayList`, `HashMap`,`HashSet`, `LinkedHashSet`, `LinkedHashMap` works out of the box with the default java implementation.

Expand Down
Loading