Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Make compilation support tinygo #991

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

springrain
Copy link
Contributor

@springrain springrain commented Oct 8, 2023

What do these changes do?

stringPtrType = reflect.TypeOf((**string)(nil)).Elem() will cause tinygo compilation error, this pr change it to:
stringPtrType = reflect.TypeOf((*string)(nil))

@chaokunyang chaokunyang changed the title 兼容tinygo编译 [Go] Make compilation support tinygo Oct 8, 2023
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@chaokunyang chaokunyang merged commit e9a74c8 into apache:main Oct 9, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants