Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-1914] Configurable Gobblin Application Master class for Yarn #3781

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

homatthew
Copy link
Contributor

@homatthew homatthew commented Sep 20, 2023

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
    The current design of the GobblinApplicationMaster has a heavy dependency on Helix task framework. Going forward, we'd like to explore Gobblin on Temporal as an alternative to Helix TF. I am requesting the ability to add specify a custom Application Master class from the Azkaban yarn app launcher to allow experimentation with different GobblinAM implementations that do not rely on Helix.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Existing unit tests / internal testing

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@homatthew homatthew force-pushed the mh-app-master-config-GOBBLIN-1914 branch 2 times, most recently from 648e2ef to c9d1a57 Compare September 20, 2023 21:05
@homatthew homatthew force-pushed the mh-app-master-config-GOBBLIN-1914 branch from c9d1a57 to 471a96e Compare September 20, 2023 21:06
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Merging #3781 (2a5ff84) into master (a289613) will increase coverage by 0.00%.
Report is 3 commits behind head on master.
The diff coverage is 83.33%.

@@            Coverage Diff            @@
##             master    #3781   +/-   ##
=========================================
  Coverage     47.30%   47.30%           
- Complexity    10953    10955    +2     
=========================================
  Files          2152     2152           
  Lines         85114    85111    -3     
  Branches       9452     9452           
=========================================
+ Hits          40263    40266    +3     
+ Misses        41197    41193    -4     
+ Partials       3654     3652    -2     
Files Changed Coverage Δ
...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java 26.58% <81.81%> (+0.49%) ⬆️
...che/gobblin/yarn/GobblinYarnConfigurationKeys.java 87.50% <100.00%> (+1.78%) ⬆️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@homatthew homatthew force-pushed the mh-app-master-config-GOBBLIN-1914 branch from e07ff95 to 3c25ab9 Compare September 21, 2023 01:09
@@ -342,7 +342,8 @@ public void initializeYarnClients(Config config) {
* @throws IOException if there's something wrong launching the application
* @throws YarnException if there's something wrong launching the application
*/
public void launch() throws IOException, YarnException, InterruptedException {
public void launch()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it really be checked? e.g. how likely is it that a caller would want to handle CNFE specifically?

we might throw something more general, like IOE... or just wrap it in RuntimeException. looking at a few other uses of reflection for dynamic instance-construction, I don't see reflection-based failures showing up in the exception signature

@@ -30,6 +30,9 @@ public class GobblinYarnConfigurationKeys {
public static final String GOBBLIN_YARN_PREFIX = "gobblin.yarn.";

// General Gobblin Yarn application configuration properties.
public static final String APP_MASTER_CLASS = GOBBLIN_YARN_PREFIX + "app.master.class";
public static final String DEFAULT_APP_MASTER_CLASS = GobblinApplicationMaster.class.getName();
Copy link
Contributor

@phet phet Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are in the same package, so potentially OK... but just noting this introduces a circular dependency between the two classes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth calling out. I can't think of a scenario where this would be a problem but open to input

@homatthew homatthew force-pushed the mh-app-master-config-GOBBLIN-1914 branch from 3c25ab9 to 2a5ff84 Compare September 21, 2023 19:25
Copy link
Contributor

@ZihanLi58 ZihanLi58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ZihanLi58 ZihanLi58 merged commit 1ca3192 into apache:master Sep 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants