Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GOBBLIN-2182] Cleanup workdir in Gobblin-on-Temporal execution #4085

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Blazer-007
Copy link
Contributor

@Blazer-007 Blazer-007 commented Dec 12, 2024

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):
  • Added cleanup for GoT execution controlled with a config - "gobblin.temporal.clean.up.work.dir"

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
  • Tested using e2e run
2024-12-11 09:32:34 PST [,,] INFO  [FsJobConfigurationManager STARTING] org.apache.gobblin.temporal.joblauncher.GobblinJobLauncher  - Deleting persisted work units for job job_virai_got_retry_test_dec_11_8_Distcp_holdem-tl_holdem-tl_distcp-push-generic_794995843_1733937791324
2024-12-11 09:32:34 PST [,,] INFO  [FsJobConfigurationManager STARTING] org.apache.gobblin.temporal.joblauncher.GobblinJobLauncher  - Deleting job state file for job job_virai_got_retry_test_dec_11_8_Distcp_holdem-tl_holdem-tl_distcp-push-generic_794995843_1733937791324
2024-12-11 09:32:34 PST [,,] INFO  [FsJobConfigurationManager STARTING] org.apache.gobblin.cluster.GobblinClusterUtils  - job state file path: hdfs://ltx1-holdem/jobs/gobblintest/gaas-temporal-workdir/gobblin-ddm/virai_got_retry_test_dec_11_8_Distcp_holdem-tl_holdem-tl_distcp-push-generic_794995843_1733937791324_121377163/job_virai_got_retry_test_dec_11_8_Distcp_holdem-tl_holdem-tl_distcp-push-generic_794995843_1733937791324.job.state
2024-12-11 09:32:34 PST [,,] INFO  [FsJobConfigurationManager STARTING] org.apache.gobblin.temporal.joblauncher.GobblinJobLauncher  - Cleaning up work directory : /tmp/gobblintest/gobblin/jobRootDir/virai_got_retry_test_dec_11_8_Distcp_holdem-tl_holdem-tl_distcp-push-generic_794995843/job_virai_got_retry_test_dec_11_8_Distcp_holdem-tl_holdem-tl_distcp-push-generic_794995843_1733937791324 for job : job_virai_got_retry_test_dec_11_8_Distcp_holdem-tl_holdem-tl_distcp-push-generic_794995843_1733937791324

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant