-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support for batch creating task through http_sd #2018
base: master
Are you sure you want to change the base?
Conversation
👍 relate pr #1791 |
Relate issue #1625 |
hi thanks for contribution. there are some conflict files need be resolved if you are time. |
# Conflicts: # collector/src/main/java/org/apache/hertzbeat/collector/dispatch/DispatchConstants.java # collector/src/main/resources/META-INF/services/org.apache.hertzbeat.collector.collect.AbstractCollect # common/src/main/java/org/apache/hertzbeat/common/entity/job/Metrics.java # common/src/main/java/org/apache/hertzbeat/common/entity/manager/Monitor.java # manager/src/main/java/org/apache/hertzbeat/manager/service/impl/MonitorServiceImpl.java
@tomsun28 |
# Conflicts: # manager/src/main/java/org/apache/hertzbeat/manager/service/impl/MonitorServiceImpl.java
@tomsun28 |
thanks, we want to merge this after publish v1.6.0 |
Got it. |
Signed-off-by: tomsun28 <[email protected]>
hi, how about the design when update the monitoring. |
Do you mean updating http_sd monitor or those monitors which are created by http_sd? |
hi, yes. Due the monitors automatic discovery by http_sd response data, when http_sd response data change, should we consider updating the automatically created monitors? |
Suggest we consider these designs in the first version to facilitate future expansion, but do not have to implement it right away. |
hi, look great!!
It is recommended to create a new table to associate their relationships. The design makes full use of existing capabilities while minimizing modifications.👍 |
We can add a tag named |
# Conflicts: # manager/src/main/java/org/apache/hertzbeat/manager/service/impl/MonitorServiceImpl.java
@tomsun28 |
The entire process of sd: |
I create a table named |
# Conflicts: # manager/src/main/java/org/apache/hertzbeat/manager/controller/MonitorsController.java # manager/src/main/java/org/apache/hertzbeat/manager/service/impl/MonitorServiceImpl.java
# Conflicts: # collector/src/main/java/org/apache/hertzbeat/collector/collect/registry/RegistryImpl.java # common/src/main/java/org/apache/hertzbeat/common/config/CommonProperties.java # common/src/main/java/org/apache/hertzbeat/common/queue/impl/KafkaCommonDataQueue.java # common/src/test/java/org/apache/hertzbeat/common/queue/impl/KafkaCommonDataQueueTest.java # manager/src/main/java/org/apache/hertzbeat/manager/service/impl/MonitorServiceImpl.java
# Conflicts: # manager/src/main/java/org/apache/hertzbeat/manager/service/impl/MonitorServiceImpl.java # manager/src/test/java/org/apache/hertzbeat/manager/service/MonitorServiceTest.java
What's changed?
Steps to batch create task through http_sd
Checklist
Add or update API