Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add version to the console banner #6417

Open
wants to merge 12 commits into
base: 2.x
Choose a base branch
from

Conversation

lightClouds917
Copy link
Contributor

@lightClouds917 lightClouds917 commented Mar 12, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

add version to the console banner,like this

image

Ⅱ. Does this pull request fix one issue?

fixes #6416

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.34%. Comparing base (c0d2ac5) to head (af89f2c).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ava/org/apache/seata/server/ServerApplication.java 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6417      +/-   ##
============================================
- Coverage     52.37%   52.34%   -0.03%     
- Complexity     6384     6385       +1     
============================================
  Files          1081     1081              
  Lines         37617    37619       +2     
  Branches       4462     4464       +2     
============================================
- Hits          19701    19692       -9     
- Misses        15962    15973      +11     
  Partials       1954     1954              
Files with missing lines Coverage Δ
...ava/org/apache/seata/server/ServerApplication.java 40.00% <50.00%> (+6.66%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leizhiyuan
Copy link
Contributor

Conflicts need to be resolved

@lightClouds917
Copy link
Contributor Author

Conflicts need to be resolved

done

@leizhiyuan leizhiyuan self-requested a review August 27, 2024 07:38
@@ -31,6 +31,96 @@ Add changes here for all PR submitted to the 2.x branch.


### optimize:
- [[#6031](https://github.com/apache/incubator-seata/pull/6031)] add a check for the existence of the undolog table
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this submission have so many doc instructions?

@xingfudeshi
Copy link
Member

@lightClouds917 Please resolve conflicting files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimize:add version to console
5 participants