-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: add StateType Enum #6891
base: 2.x
Are you sure you want to change the base?
optimize: add StateType Enum #6891
Conversation
common/src/main/java/org/apache/seata/common/util/CollectionUtils.java
Outdated
Show resolved
Hide resolved
import java.util.HashMap; | ||
import java.util.List; | ||
import java.util.Map; | ||
import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import java.util.*; | |
import java.util.ArrayList; | |
import java.util.Collection; | |
import java.util.HashMap; | |
import java.util.List; | |
import java.util.Map; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6891 +/- ##
=========================================
Coverage 52.61% 52.62%
- Complexity 6579 6580 +1
=========================================
Files 1126 1127 +1
Lines 39928 39947 +19
Branches 4680 4683 +3
=========================================
+ Hits 21010 21023 +13
- Misses 16916 16918 +2
- Partials 2002 2006 +4
|
} | ||
|
||
TaskStateRouter taskStateRouter = new TaskStateRouter(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So many getValues are not very elegant, it is recommended to centralize them in the method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
…o dev-2.3.0-SNAPSHOT-20240928
Ⅰ. Describe what this PR did
optimize: computeIfAbsent get twice
optimize: createProcessorController code order
optimize: add StateType Enum
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews