Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KARAF-7145] Add kube namespace config option #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CMoH
Copy link

@CMoH CMoH commented May 24, 2022

I still have to test this, but I will certainly have to, because I need to put this setting to use.

From the code it seems this is all that's needed to configure the kubernetes client to work within the confines of a single namespace. Any notes/hints are welcome.

@jbonofre jbonofre self-requested a review May 25, 2022 07:08
@CMoH
Copy link
Author

CMoH commented Feb 13, 2023

Tested OK (with some additions): I added a kube-client autoconfiguration facility and made this work (avoiding some NPE traps). Also added some docs which I would have found useful while putting the Kubernetes discovery mechanism in use.

Keep me posted if you find this interesting.

@fpapon fpapon self-requested a review March 8, 2023 06:06
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CMoH Thanks for your contribution!
I think this is a good improvement to add the namespace.
Can you rebase to have the jenkins build configuration up-to-date and squash the commits please?

@jbonofre
Copy link
Member

jbonofre commented Mar 8, 2023

FYI, there is a complete refactoring of Cellar ongoing (Cellar 3.x).
This kind of change is valid only for Cellar 2.x.

@CMoH
Copy link
Author

CMoH commented Mar 8, 2023

FYI, there is a complete refactoring of Cellar ongoing (Cellar 3.x). This kind of change is valid only for Cellar 2.x.

You might be using these version references (3.x, 2.x) internally. The current patch(es) were made against the main branch of the cellar repo, which is supposed to build 4.2.2-SNAPSHOT. Will these refactorings bump the version to 5.x.x? Or to 4.3.x?

@fpapon I will squash the commits and rebase on the current main

Add new kubernetes.autoConfig option, leveraging fabric8 kubernetes
client Config.autoConfigure() function.

Fix NPE during node startup if kubernetes discovery provides pod IPs
before hazelcast is up.
Fix NPE when handling empty TLS options.

Document use of kubernetes.autoConfig and kubernetes.namespace. Add
sample on using kubernetes service accounts automatically and manually
@CMoH CMoH force-pushed the karaf-7145_kube-namespace-setting branch from f902d84 to b5ad48d Compare March 8, 2023 21:32
@fpapon fpapon self-requested a review March 9, 2023 06:35
@jbonofre
Copy link
Member

jbonofre commented Mar 9, 2023

Sorry I wasn't clear: I will create cellar 4.x branch. Mail will become cellar 5.x and will welcome the big refactoring (locally on my machine for now).

@CMoH
Copy link
Author

CMoH commented Mar 12, 2023

Rebased. Seems all tests pass

@jbonofre
Copy link
Member

@CMoH thanks ! Let me do a new pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants