-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KARAF-7145] Add kube namespace config option #86
base: main
Are you sure you want to change the base?
Conversation
Tested OK (with some additions): I added a kube-client autoconfiguration facility and made this work (avoiding some NPE traps). Also added some docs which I would have found useful while putting the Kubernetes discovery mechanism in use. Keep me posted if you find this interesting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CMoH Thanks for your contribution!
I think this is a good improvement to add the namespace.
Can you rebase to have the jenkins build configuration up-to-date and squash the commits please?
FYI, there is a complete refactoring of Cellar ongoing (Cellar 3.x). |
You might be using these version references (3.x, 2.x) internally. The current patch(es) were made against the main branch of the cellar repo, which is supposed to build 4.2.2-SNAPSHOT. Will these refactorings bump the version to 5.x.x? Or to 4.3.x? @fpapon I will squash the commits and rebase on the current main |
Add new kubernetes.autoConfig option, leveraging fabric8 kubernetes client Config.autoConfigure() function. Fix NPE during node startup if kubernetes discovery provides pod IPs before hazelcast is up. Fix NPE when handling empty TLS options. Document use of kubernetes.autoConfig and kubernetes.namespace. Add sample on using kubernetes service accounts automatically and manually
f902d84
to
b5ad48d
Compare
Sorry I wasn't clear: I will create cellar 4.x branch. Mail will become cellar 5.x and will welcome the big refactoring (locally on my machine for now). |
Rebased. Seems all tests pass |
@CMoH thanks ! Let me do a new pass. |
I still have to test this, but I will certainly have to, because I need to put this setting to use.
From the code it seems this is all that's needed to configure the kubernetes client to work within the confines of a single namespace. Any notes/hints are welcome.