Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a comment to warn that it is not secure #317

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

YYTVicky
Copy link

@YYTVicky YYTVicky commented Mar 1, 2020

No description provided.

@YYTVicky
Copy link
Author

Hi,

could I know why my PR didn't pass the checks, the PR is a comment. Our tool report that keeps checkClientTrusted and checkServerTrusted empty body is not secure.

Thanks!

@bessbd
Copy link
Member

bessbd commented Apr 30, 2020

Hi @YYTVicky ,

Thank you for this PR!

I think that was an issue with the build with all pull requests failing at that time. Can you please rebase your PR on master HEAD? The "Update branch" button should be sufficient.

@rgoers
Copy link
Member

rgoers commented Oct 8, 2022

When I try to apply this patch I am getting merge conflicts. I don't there actually are any, just that the fork needs to be brought up to date. Can you please do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants