NIFI-13853: Added the ability to filter by all to the Advanced Rules page #9371
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HunterG6700
changed the title
exceptionfactory
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Thanks for the contribution @HunterG6700. I noted some code formatting issues, and a labeling recommendation, but I will defer to @mcgilman or @scottyaslan for additional input from a frontend implementation perspective.
| return actions; | ||
| } | ||
| } else if (filterType.value === 'action') { | ||
| var actions = []; |
There was a problem hiding this comment.
The indentation appears to be off in this new block, in comparison with the other blocks.
There was a problem hiding this comment.
Thank you I didn't notice that I thought my IDE auto formatted it.
| @@ -201,6 +201,9 @@ var ua = { | |||
| }, { | |||
| text: 'by action', | |||
| value: 'action' | |||
| }, { | |||
| text: 'filter everything', | |||
There was a problem hiding this comment.
Following the existing pattern, it seems like it would be better to call this by any field or by any property.
HunterG6700
force-pushed
the
NIFI-13853
branch
from
0732c6d
to
b319bb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-13853
Added the ability to filter on text anywhere in the UpdateAttribute advanced rules. Currently you can filter by matching text in Rule name, the Conditions, Comments, and the Actions. So I added an option to filter "Anywhere", if the search string matches anywhere in a rule, that rule will be displayed.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation