NIFI-13868: add pg-delete command to Nifi Toolkit #9388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Co-authored-by: David Handermann <[email protected]>
grishick
force-pushed
the
NIFI-13868-main
branch
from
a2e515a
to
abec337
Compare
exceptionfactory
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Thanks for putting together this PR @grishick. I noted some styling and wording suggestions, but it looks straightforward on initial review.
| */ | ||
| public class PGDelete extends AbstractNiFiCommand<StringResult> { | ||
|
|
||
| public PGDelete() { |
There was a problem hiding this comment.
The spacing of these class properties looks like it needs to be adjusted from eight spaces to four, for the initial indentation.
|
|
||
| @Override | ||
| public String getDescription() { | ||
| return "Deletes the given process group."; |
There was a problem hiding this comment.
As @pvillard31 on the other PR, it would be helpful to add a bit more detail here. Recommend the following:
Suggested change
| return "Deletes the given process group."; | |
| return "Deletes the given process group. Deleting a process group requires, stopping all Processors, disabling all Controller Services, and emptying all Queues."; |
| import org.apache.nifi.toolkit.cli.impl.result.StringResult; | ||
| import org.apache.nifi.web.api.entity.ProcessGroupEntity; | ||
|
|
||
|
|
There was a problem hiding this comment.
Spacing
Suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-13868
Adding
pg-deletecommand to Nifi Toolkit. The command works the same way as deleting a process group via UI. If there are messages in PG queue, deletion will fail. I ported this change from Anetac's Nifi fork where I made it a while ago. We have been using this feature in production at Anetac for months now.The code change to
mainbranch is smaller than the one to support/nifi-1.x branch, because @markap14 has already added some of the functionality under NIFI-12898Related PR for support/nifi-1.x branch: #9387
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation