Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#502] batch message support #526

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

kaori-seasons
Copy link

What is the purpose of the change

related to issues-502

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@kaori-seasons kaori-seasons changed the title feat: batch message support [ISSUE#502] batch message support Feb 14, 2023
@kaori-seasons
Copy link
Author

kaori-seasons commented Feb 15, 2023

@aaron-ai @francisoliverlee Can you help me start ci?

@aaron-ai
Copy link
Member

@aaron-ai @francisoliverlee Can you help me start ci?

OK

Copy link
Contributor

@RongtongJin RongtongJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @complone , Could you add a sample to show how to use it ?

@kaori-seasons
Copy link
Author

Hi @complone , Could you add a sample to show how to use it ?

In the unit test, testBatchGetMessages can be used as an example. This week I will add

@panzhi33
Copy link
Contributor

consumeBatchSize parameter needs to be added, otherwise batch consumption will not take effect, and there will still be one item at a time

* The consumeMessageBatchMaxSize of consumer.
* @return
*/
int consumeMessageBatchMaxSize() default 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why consumeMessageBatchMaxSize default is zero and delayLevelWhenNextConsume default is 1024 ?

@itlidaye
Copy link

When will it be released ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants