SAMZA-2497: Close MetadataResourceUtil when job is stopped #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xinyuiscool if you could review this rb |
Sanil15
requested changes
Apr 7, 2020
| @@ -312,7 +313,7 @@ JobModel readJobModelFromMetadataStore(String zkJobModelVersion) { | |||
| @VisibleForTesting | |||
| void loadMetadataResources(JobModel jobModel) { | |||
| try { | |||
| MetadataResourceUtil metadataResourceUtil = createMetadataResourceUtil(jobModel, config); | |||
| metadataResourceUtil = createMetadataResourceUtil(jobModel, config); | |||
There was a problem hiding this comment.
Where is metadataResourceUtil#stop is being stopped for ZkJobCoordinator?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symptoms: Error message about a Kafka consumer allocated but not closed appears in our log messages
Cause: The MetadataResouceUtil has a Kafka checkpoint manager that is never closed in our code. A LifeCycleAwareConsumer sees this and complains about it.
Fix:: Add a stop in MetadataResourceUtil that will close the checkpoint manager in it. Then have MetadataResourceUtil.stop called everywhere it's used when the job is stopped
Tests: Any job that uses ProcessJob or PassthroughJobCoordinator will see errors in the log files about a Kafka consumer allocated but not closed. With this fix in, that error shouldn't appear