Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMZA-2778: Remove deprecated constructor. #1673

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ehoner
Copy link
Contributor

@ehoner ehoner commented Jun 22, 2023

Remove @Deprecated. This annotation was missed when updating #1662 - (comment).

@mynameborat
Copy link
Contributor

Will have it merged once the checks pass

@ehoner
Copy link
Contributor Author

ehoner commented Jun 22, 2023

Thank you @mynameborat . I was looking at the failure, do you know how/if the error relates to this PR? The failure is in TestSamzaSqlEndToEnd.

CI build: 8.0.232

> Task :samza-test_2.12:test

testEndToEndStreamTableInnerJoinWithUdf FAILED
    java.lang.AssertionError: expected:<20> but was:<19>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:645)
        at org.junit.Assert.assertEquals(Assert.java:631)
        at org.apache.samza.test.samzasql.TestSamzaSqlEndToEnd.testEndToEndStreamTableInnerJoinWithUdf(TestSamzaSqlEndToEnd.java:892)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants