Minor refactor for SelectStatementContext#containsTableSubquery (#32278)

apache · Jul 26, 2024 · bc673ba · bc673ba
1 parent c7d5e37
commit bc673ba
Showing 1 changed file with 1 addition and 12 deletions.
diff --git a/.../org/apache/shardingsphere/infra/binder/context/statement/dml/SelectStatementContext.java b/.../org/apache/shardingsphere/infra/binder/context/statement/dml/SelectStatementContext.java
@@ -403,18 +403,7 @@ private void appendInheritedSimpleTables(final Collection<TableSegment> inherite
      * @return whether sql statement contains table subquery segment or not
      */
     public boolean containsTableSubquery() {
-        return getSqlStatement().getFrom().isPresent() && isAllSubqueryTable(getSqlStatement().getFrom().get()) || getSqlStatement().getWithSegment().isPresent();
-    }
-
-    private boolean isAllSubqueryTable(final TableSegment tableSegment) {
-        return tableSegment instanceof SubqueryTableSegment || isAllSubqueryTableInJoinTable(tableSegment);
-    }
-
-    private boolean isAllSubqueryTableInJoinTable(final TableSegment tableSegment) {
-        if (tableSegment instanceof JoinTableSegment) {
-            return isAllSubqueryTable(((JoinTableSegment) tableSegment).getLeft()) && isAllSubqueryTable(((JoinTableSegment) tableSegment).getRight());
-        }
-        return false;
+        return getSqlStatement().getFrom().isPresent() && getSqlStatement().getFrom().get() instanceof SubqueryTableSegment || getSqlStatement().getWithSegment().isPresent();
     }
 
     /**