Skip to content

Commit

Permalink
Add todo on ShardingInsertValuesTokenTest (#33687)
Browse files Browse the repository at this point in the history
  • Loading branch information
terrymanu authored Nov 16, 2024
1 parent 368e3f1 commit eca7bd0
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class ShardingInsertValuesTokenTest {

@Test
void assertToStringWithRouteUnit() {
// TODO This test case may not necessary; the trailing parentheses should not be there. Is there too much protective coding in main code? @duanzhengqiang
assertThat(createInsertValuesToken().toString(createRouteUnit()), is("('foo', 'bar'), ()"));
}

Expand All @@ -58,6 +59,7 @@ private RouteUnit createRouteUnit() {

@Test
void assertToStringWithoutRouteUnit() {
// TODO This test case may not necessary; the trailing parentheses should not be there. Is there too much protective coding in main code? @duanzhengqiang
assertThat(createInsertValuesToken().toString(), is("('foo', 'bar'), (), ()"));
}
}

0 comments on commit eca7bd0

Please sign in to comment.