Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library to serve building GraalVM Native Image #21552

Closed
wants to merge 5 commits into from

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Oct 13, 2022

For #21347.

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

…m-metadata

� Conflicts:
�	mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/persist/service/schema/TableMetaDataPersistService.java
�	mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/persist/service/schema/ViewMetaDataPersistService.java
@linghengqian linghengqian changed the title Update library to serve unit testing inside GraalVM Native Image Update library to serve build GraalVM Native Image Oct 13, 2022
@linghengqian linghengqian changed the title Update library to serve build GraalVM Native Image Update library to serve building GraalVM Native Image Oct 13, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #21552 (0275ffd) into master (22313c9) will decrease coverage by 0.21%.
The diff coverage is 8.33%.

❗ Current head 0275ffd differs from pull request most recent head d51be2b. Consider uploading reports for the commit d51be2b to get more accurate results

@@             Coverage Diff              @@
##             master   #21552      +/-   ##
============================================
- Coverage     61.21%   60.99%   -0.22%     
- Complexity     2509     2510       +1     
============================================
  Files          4109     4115       +6     
  Lines         57124    57346     +222     
  Branches       7560     7592      +32     
============================================
+ Hits          34967    34981      +14     
- Misses        19222    19430     +208     
  Partials       2935     2935              
Impacted Files Coverage Δ
...etadata/data/ShardingStatisticsTableCollector.java 0.00% <0.00%> (ø)
...uilder/dialect/MySQLShardingSphereDataBuilder.java 0.00% <0.00%> (ø)
...r/dialect/PostgreSQLShardingSphereDataBuilder.java 0.00% <0.00%> (ø)
...nfra/yaml/data/pojo/YamlShardingSphereRowData.java 0.00% <0.00%> (ø)
...ra/yaml/data/pojo/YamlShardingSphereTableData.java 0.00% <0.00%> (ø)
...ta/swapper/YamlShardingSphereTableDataSwapper.java 0.00% <0.00%> (ø)
...line/core/api/impl/AbstractPipelineJobAPIImpl.java 0.00% <ø> (ø)
...ine/core/api/impl/GovernanceRepositoryAPIImpl.java 0.00% <0.00%> (ø)
...e/api/impl/InventoryIncrementalJobItemAPIImpl.java 0.00% <0.00%> (ø)
...ore/api/impl/PipelineDataSourcePersistService.java 0.00% <0.00%> (ø)
... and 24 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@linghengqian
Copy link
Member Author

  • Some magical GHA issues happened in this PR. Atomikos has added a new keepaliveTime property from 5.0.8 to 5.0.9. I switch atomikos.version in different commits of the PR. If GHA keeps the cache, I can easily see this problem... But the process of changing atomikos.version happens in the child pom.xml for the module, not sure what to do.

  • I'll submit a new PR on the new branch shortly.

  • mmexport1665726063413.png

@linghengqian linghengqian deleted the junit-next branch October 14, 2022 12:22
@linghengqian
Copy link
Member Author

New PR at #21571 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants