Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade antlr4 to 4.10.1 #23504

Closed
wants to merge 1 commit into from
Closed

Conversation

zhfeng
Copy link
Contributor

@zhfeng zhfeng commented Jan 11, 2023

Fixes quarkiverse/quarkus-shardingsphere-jdbc#84.

Changes proposed in this pull request:

  • Bump antlr4 to 4.10.1 which should be helpful to quarkus-shardingshpere-jdbc.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@zhfeng
Copy link
Contributor Author

zhfeng commented Jan 11, 2023

Hmm, it looks like antlr-4.10.1 is only for JDK > 11. So is there any plan for sharding-sphere to drop support of JDK 8?

@TeslaCN
Copy link
Member

TeslaCN commented Jan 11, 2023

Duplicate with #20008.

@zhfeng
Copy link
Contributor Author

zhfeng commented Jan 11, 2023

Yeah, I'm sorry to miss the similar PR. Thanks @TeslaCN !

@zhfeng zhfeng closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus application is failing with the uncompatite antl4 runtime
2 participants