Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open the resource:/ related FileSystem for JDBCRepositorySQLLoader in the GraalVM Native Image environment #29009

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

linghengqian
Copy link
Member

For #29000.

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian marked this pull request as ready for review November 11, 2023 06:07
Copy link
Member Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Naturally, we can continue to keep similar operations within specific unit tests, because the current behavior is actually consistent with the behavior in Jar. Calling resource URI inside Jar also requires opening FileSystem. I'm still looking for a review.

@terrymanu terrymanu added this to the 5.4.2 milestone Nov 11, 2023
@terrymanu terrymanu merged commit c3bea55 into apache:master Nov 11, 2023
133 checks passed
@linghengqian linghengqian deleted the open-file-system branch November 11, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants