Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraalVM Reachability Metadata and corresponding nativeTest for Zookeeper integration #29425

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Dec 17, 2023

For #29052.

Changes proposed in this pull request:

  • Add GraalVM Reachability Metadata and corresponding nativeTest for Zookeeper integration.
  • The destruction of the Docker Image created by MySQLTest and OpenGaussTest is required to ensure normal execution of unit tests. This PR uses testcontainers-java to ensure that even if nativeTest fails, the corresponding containers can be forcibly destroyed.
  • org.apache.shardingsphere.test.natived.** should be excluded in advance in User Code Filter instead of being deferred to Extra Filter processing. This reduces the effort of manually processing JSON. This makes the JSON file change dramatically in this PR.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian force-pushed the new-zookeeper branch 4 times, most recently from 1e0cbff to a9ec738 Compare December 17, 2023 16:01
@linghengqian linghengqian marked this pull request as ready for review December 17, 2023 16:02
@terrymanu terrymanu added this to the 5.4.2 milestone Dec 19, 2023
terrymanu
terrymanu previously approved these changes Dec 19, 2023
@tristaZero tristaZero merged commit 4fd6850 into apache:master Dec 20, 2023
133 checks passed
@linghengqian linghengqian deleted the new-zookeeper branch December 20, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants