Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JDBCStreamQueryResult.java #33661

Closed
wants to merge 1 commit into from
Closed

Conversation

fyeeme
Copy link
Contributor

@fyeeme fyeeme commented Nov 14, 2024

DateTime column support prased as ZonedDatetime

Fixes #33660.

Changes proposed in this pull request:

  • Support Sharding-JDBC to parse dateTime as ZonedDateTime.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

DateTime column support prased as ZonedDatetime
Copy link
Member

@terrymanu terrymanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI are all broken

@fyeeme
Copy link
Contributor Author

fyeeme commented Nov 15, 2024

I will fix it asap. @terrymanu

@fyeeme
Copy link
Contributor Author

fyeeme commented Nov 15, 2024

closed as change merge request branch

@fyeeme fyeeme closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharding not support ZoneDateTime
2 participants