Apply MQE on K8s layer UI-templates #11350
Conversation
wu-sheng
added
backend
skywalking-ui
Outdated
There was a problem hiding this comment.
It seems an old version. A mistake sync?
There was a problem hiding this comment.
I think it should be a mistake. @smartboy37597 Please revert it.
There was a problem hiding this comment.
It should be a sync error, I will try to solve it.
There was a problem hiding this comment.
ui is synchronized
|
ebpf cases have errors. Something is not matched. cc @mrproliu |
| - metric: | ||
| labels: | ||
| - key: _ | ||
| value: "false-http-172.18.0.6:80:50" |
There was a problem hiding this comment.
Does the value of the label look like a dynamic IP?
There was a problem hiding this comment.
I feel different KinD would provide different IP pools. So, don't use the specific addresses.
There was a problem hiding this comment.
process_relation_client_write_rtt_time_percentile and process_relation_client_write_exe_time_percentile
process_relation_server_write_rtt_time_percentile and process_relation_server_write_exe_time_percentile
Can the metrics return the same value as process_relation_http1_request_package_size_percentile and process_relation_http1_response_package_size_percentile is consistent, and I think the label value of http1 is better.
There was a problem hiding this comment.
How TCP could be as same as HTTP?
This PR should keep a metric to MQE, let's don't introduce more changes in here.
There was a problem hiding this comment.
I think it is enough for you to verify that the value of the label is not empty.
There was a problem hiding this comment.
@smartboy37597 I will approve the rerun once you fix the tests.
There was a problem hiding this comment.
I've fixed it and the e2e test are passing.
|
I will take care of |
| @@ -1,19 +1,3 @@ | |||
| /** | |||
There was a problem hiding this comment.
@kezhenxu94 Should we keep the license header in the UI template files?
There was a problem hiding this comment.
I think we no longer need these headers: #11184 (comment)
There was a problem hiding this comment.
@smartboy37597 Could you follow up on another PR to remove other existing headers to keep them consistent?
There was a problem hiding this comment.
@smartboy37597 Could you follow up on another PR to remove other existing headers to keep them consistent?
Okey, I'm going to delete all UI headers in a new PR.
|
@smartboy37597 We only have OpenFunction and topology related settings pending on the immigration to MQE. |
Okey, i got it. |
CHANGESlog.Here are some UI and e2e test screenshots.
