Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BanyanDB Java Client to 0.5.0 #11370

Merged
merged 12 commits into from
Oct 4, 2023
Merged

Update BanyanDB Java Client to 0.5.0 #11370

merged 12 commits into from
Oct 4, 2023

Conversation

lujiajing1126
Copy link
Contributor

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@lujiajing1126 lujiajing1126 added the dependencies Pull requests that update a dependency file label Oct 3, 2023
@lujiajing1126 lujiajing1126 added this to the 9.7.0 milestone Oct 3, 2023
@lujiajing1126 lujiajing1126 self-assigned this Oct 3, 2023
@wu-sheng
Copy link
Member

wu-sheng commented Oct 3, 2023

FYI @wankai123

wankai123
wankai123 previously approved these changes Oct 3, 2023
@wu-sheng
Copy link
Member

wu-sheng commented Oct 4, 2023

@lujiajing1126 Please fix this #11370 (comment).

The Istio relative e2e are always failure due to GHA issues. I have setup the workflow to skip them.

@wu-sheng
Copy link
Member

wu-sheng commented Oct 4, 2023

configuration-vocabulary.md should be updated too.

wu-sheng
wu-sheng previously approved these changes Oct 4, 2023
wu-sheng
wu-sheng previously approved these changes Oct 4, 2023
@wu-sheng
Copy link
Member

wu-sheng commented Oct 4, 2023

I have tried rerun, profiling e2e with BanyanDB fails. I am not sure whether it is relative.

@wu-sheng
Copy link
Member

wu-sheng commented Oct 4, 2023

@lujiajing1126 It still fails, it seems server side has some issues.

@lujiajing1126
Copy link
Contributor Author

@lujiajing1126 It still fails, it seems server side has some issues.

Caused by: io.grpc.StatusRuntimeException: UNKNOWN: fail to analyze the query request for measure instance_traffic_minute: mandatory index rule conf:name:"id" op:BINARY_OP_IN value:{str_array:{value:"c3FydA==.1_dGVzdC1pbnN0YW5jZQ=="}}: unsupported condition operation: invalid query message
	at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:271) ~[grpc-stub-1.53.0.jar:1.53.0]
	at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:252) ~[grpc-stub-1.53.0.jar:1.53.0]
	at io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:165) ~[grpc-stub-1.53.0.jar:1.53.0]
	at org.apache.skywalking.banyandb.measure.v1.MeasureServiceGrpc$MeasureServiceBlockingStub.query(MeasureServiceGrpc.java:263) ~[banyandb-java-client-0.5.0.jar:0.5.0]
	at org.apache.skywalking.banyandb.v1.client.BanyanDBClient.lambda$query$4(BanyanDBClient.java:386) ~[banyandb-java-client-0.5.0.jar:0.5.0]
	at org.apache.skywalking.banyandb.v1.client.grpc.HandleExceptionsWith.callAndTranslateApiException(HandleExceptionsWith.java:45) ~[banyandb-java-client-0.5.0.jar:0.5.0]
	at org.apache.skywalking.banyandb.v1.client.BanyanDBClient.query(BanyanDBClient.java:383) ~[banyandb-java-client-0.5.0.jar:0.5.0]
	at org.apache.skywalking.oap.server.storage.plugin.banyandb.BanyanDBStorageClient.query(BanyanDBStorageClient.java:128) ~[storage-banyandb-plugin-9.7.0-SNAPSHOT.jar:9.7.0-SNAPSHOT]
	at org.apache.skywalking.oap.server.storage.plugin.banyandb.stream.AbstractBanyanDBDAO.query(AbstractBanyanDBDAO.java:129) ~[storage-banyandb-plugin-9.7.0-SNAPSHOT.jar:9.7.0-SNAPSHOT]
	at org.apache.skywalking.oap.server.storage.plugin.banyandb.stream.AbstractBanyanDBDAO.query(AbstractBanyanDBDAO.java:115) ~[storage-banyandb-plugin-9.7.0-SNAPSHOT.jar:9.7.0-SNAPSHOT]
	at org.apache.skywalking.oap.server.storage.plugin.banyandb.stream.AbstractBanyanDBDAO.query(AbstractBanyanDBDAO.java:80) ~[storage-banyandb-plugin-9.7.0-SNAPSHOT.jar:9.7.0-SNAPSHOT]
	at org.apache.skywalking.oap.server.storage.plugin.banyandb.measure.BanyanDBMetadataQueryDAO.getInstances(BanyanDBMetadataQueryDAO.java:157) ~[storage-banyandb-plugin-9.7.0-SNAPSHOT.jar:9.7.0-SNAPSHOT]
	at org.apache.skywalking.oap.server.core.profiling.continuous.ContinuousProfilingQueryService.queryContinuousProfilingMonitoringInstances(ContinuousProfilingQueryService.java:150) ~[server-core-9.7.0-SNAPSHOT.jar:9.7.0-SNAPSHOT]
	at org.apache.skywalking.oap.query.graphql.resolver.ContinuousProfilingQuery.queryContinuousProfilingMonitoringInstances(ContinuousProfilingQuery.java:54) ~[query-graphql-plugin-9.7.0-SNAPSHOT.jar:9.7.0-SNAPSHOT]
	at jdk.internal.reflect.GeneratedMethodAccessor130.invoke(Unknown Source) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:?]
	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:?]
	at graphql.kickstart.tools.resolver.MethodFieldResolverDataFetcher.get(MethodFieldResolver.kt:282) ~[graphql-java-tools-13.0.1.jar:?]
	... 44 more

The problem is id index is missing for instance_traffic_minute. Any idea why this could work in v0.4.0? @hanahmily

@wu-sheng
Copy link
Member

wu-sheng commented Oct 4, 2023

@hanahmily told me its an OAP banyandb storage plugin bug. He will comment soon.
Let's see.

There is a bug for 0.4 too, but accidentally work due to bugs at both sides.

@wu-sheng
Copy link
Member

wu-sheng commented Oct 4, 2023

@lujiajing1126 We should have removed ID column, right? But in BanyanDBMetadataQueryDAO, getInstances doesn't work like getInstance. It still uses the ID as query condition, rather than decoding the ID and use series IDs.

I think this is the root cause.

@lujiajing1126
Copy link
Contributor Author

@lujiajing1126 We should have removed ID column, right? But in BanyanDBMetadataQueryDAO, getInstances doesn't work like getInstance. It still uses the ID as query condition, rather than decoding the ID and use series IDs.

I think this is the root cause.

I see. Fixed.

@wu-sheng wu-sheng merged commit 338ebca into master Oct 4, 2023
156 of 164 checks passed
@wu-sheng wu-sheng deleted the update-banyandb-client branch October 4, 2023 14:24
liangyepianzhou pushed a commit to liangyepianzhou/skywalking that referenced this pull request Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants