Bump up netty to 4.1.99 #11389
Merged
Bump up netty to 4.1.99 #11389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
previously approved these changes
Oct 9, 2023
|
As I've noticed from grpc-java repo, grpc/grpc-java#10401, netty 4.1.94 suffers from performance issue. |
|
Interesting. @kezhenxu94 Is 4.1.93 good enough from CVE perspective? |
lujiajing1126
requested changes
Oct 9, 2023
pom.xml
Outdated
| @@ -170,7 +170,7 @@ | |||
|
|
|||
| <!-- core lib dependency --> | |||
| <grpc.version>1.53.0</grpc.version> | |||
| <netty.version>4.1.86.Final</netty.version> | |||
| <netty.version>4.1.94.Final</netty.version> | |||
There was a problem hiding this comment.
What about 4.1.97. As it is used by grpc-java
There was a problem hiding this comment.
@lujiajing1126 We manage netty version separately AFAIK. We ignore the gRPC-Java dependency. The skywalking-eye license check verified the final use.
|
The regression is fixed in 4.1.96.Final and now i bump to 4.1.99.Final |
lujiajing1126
approved these changes
Oct 9, 2023
liangyepianzhou
pushed a commit
to liangyepianzhou/skywalking
that referenced
this pull request
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGESlog.