Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-50137][HIVE] Avoid fallback to Hive-incompatible ways when table creation fails by thrift exception #48668

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wecharyu
Copy link
Contributor

@wecharyu wecharyu commented Oct 26, 2024

What changes were proposed in this pull request?

Enhance the datasource table creation, do not fallback to hive incompatible way if failure was caused by thrift exception.

Why are the changes needed?

Thrift exception is unrelated to hive compatibility of datasource table, so fallback is unnecessary in this case.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Add a unit test:

mvn test -Dtest=none -Dsuites="org.apache.spark.sql.hive.HiveExternalCatalogSuite @SPARK-50137: Avoid fallback to Hive-incompatible ways on thrift exception" -pl :spark-hive_2.13

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Oct 26, 2024
@LuciferYang LuciferYang changed the title [SPARK-50137][HIVE] Avoid fallback to Hive-incompatible ways when tab… [SPARK-50137][HIVE] Avoid fallback to Hive-incompatible ways when table creation fails by thrift exception Oct 27, 2024
@wecharyu
Copy link
Contributor Author

@LuciferYang @wangyum @sunchao could you please review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant